T09 · Insecure Skill Coding Practices
- Location
SKILL.md:424- Finding
Unapproved Removal of Repository Security-Analysis Configuration
- Content
View full analysis
Vulnerability Details
File Location:
SKILL.md, line 424
Vulnerability Type: Destructive modification of security tooling outside the authorized issue scope
Risk Level: MediumCode Snippet:
markdown - ✅ Remove SonarQube scanner files that may be present, such as `sonar-project.properties`, `sonar-scanner.properties`, etc. Also remove other scanners, such as the `SonarScanner for Maven` usually present in the POM.xml, since our pipeline is autonomous and does not depend on these files to work. (For now, keep only SonarQube-related configurations in `.csproj` files).Technical Analysis
The skill instructs the implementing agent to remove existing SonarQube configuration files and scanner integration from Maven configuration. This is a repository-wide modification that is not conditioned on a downloaded SonarQube issue explicitly requiring the change.
The instruction has no mandatory confirmation, dry-run, exact-target allowlist, or requirement to present a proposed diff. It also conflicts with the scope restriction at
SKILL.md:628, which directs the agent to fix exclusively the issues listed insonarqube_issues.json.The trust boundary is crossed when a user authorizes analysis and remediation of specified SonarQube findings, but the bundled skill instruction expands that authorization into deleting unrelated security-analysis configuration. This is a reachable high-risk behavior, although the reviewed evidence does not establish malicious intent.
Attack Path
- A user invokes the skill to analyze and remediate selected SonarQube issues.
- The skill generates approved specifications and hands them to the implementation workflow.
- During implementation or validation, the agent follows the unconditional cleanup instruction at line 424.
- The agent deletes
sonar-project.properties,sonar-scanner.properties, or scanner configuration frompom.xml, even when no selected issue author ...[truncated 733 chars]
- Remediation
View remediation
Remediation Suggestions
- Remove the unconditional instruction to delete scanner files and Maven scanner configuration.
- Preserve existing security-analysis configuration by default.
- Permit scanner configuration changes only when a specific issue in
sonarqube_issues.jsonexplicitly requires them. - Before any deletion, enumerate the exact files and configuration sections, present the proposed diff, and obtain explicit user confirmation.
- Add a dry-run mode and create a recoverable backup or rely on a verified clean version-control state before destructive changes.
- Restrict modifications to an allowlist of issue-referenced paths and reject unrelated cleanup actions.
- Reconcile the workflow with the scope restriction at
SKILL.md:628so implementation agents cannot interpret general cleanup guidance as authorization to modify unrelated files.