Back to skill

Security audit

1688 Item Select

Security checks for vulnerabilities and agentic risk

Overview

The skill is broadly aligned with 1688 product selection, but its setup path stores and forwards a merchant Access Key with weak disclosure and safeguards.

Review before installing. Use a least-privilege 1688 AK, verify OPENCLAW_GATEWAY_URL before running configure, and protect or avoid plaintext openclaw.json storage where possible. Expect signed requests and usage telemetry to be sent to the 1688/OpenClaw gateway. No artifact-backed evidence of destructive behavior, backdoors, or unrelated exfiltration was found.

Vulnerability Patterns
  • Insecure DependenciesIntroduces malicious components through unsafe dependency sources
  • Insecure Skill Coding PracticesFinds exploitable flaws such as hardcoded secrets or command injection
  • Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
  • Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
  • Remote Payload Retrieval and ExecutionFetches external code whose behavior can change after review
Findings (2)

T09 · Insecure Skill Coding Practices

Warning
Location
scripts/capabilities/configure/service.py:42
Finding

Access Key Stored in Plaintext Without Enforced File Permissions

Content
View full analysis
bool: try: config: dict = {} if CONFIG_PATH.exists(): try: with open(CONFIG_PATH, "r", encoding="utf-8") as f: content = f.read().strip() if content: config = json.loads(content) except json.JSONDecodeError: return False config.setdefault("skills", {}) config["skills"].setdefault("entries", {}) config["skills"]["entries"].setdefault(SKILL_NAME, {}) skill_entry = config["skills"]["entries"][SKILL_NAME] skill_entry["apiKey"] = api_key if "env" in skill_entry and isinstance(skill_entry["env"], dict): skill_entry["env"].pop("ALI_1688_AK", None) if not skill_entry["env"]: del skill_entry["env"] CONFIG_PATH.parent.mkdir(parents=True, exist_ok=True) with open(CONFIG_PATH, "w", encoding="utf-8") as f: json.dump(config, f, ensure_ascii=False, indent=2) return True except Exception: return False ``` ### Technical Analysis When gateway-based configuration is unavailable, the Skill falls back to writing the merchant Access Key to `openclaw.json`. The credential is stored as plaintext in the `apiKey` property. The code creates the parent directory and writes the file using ordinary Python file operations, but it does not set or verify restrictive permissions. Consequently, the effective access controls depend on the process umask and any pre-existing directory or file permissions. If those permissions allow access by other local users or processes, the credential can be disclosed. This exceeds secure minimu ...[truncated 1579 chars]
Remediation
View remediation

T08 · Insecure Dependencies

Note
Location
requirements.txt:1
Finding

Unpinned HTTP Dependency Creates Non-Reproducible Supply-Chain Exposure

Content
View full analysis
Remediation
View remediation
Vulnerability Patterns
  • Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
  • Privilege EscalationExcessive Permissions, Sudo/Root Execution, Credential Access
  • Excessive AgencyUnrestricted Tool Access, Autonomous Decision Making, Scope Creep
  • Trigger AbuseOverly Broad Trigger, Shadow Command Trigger, Keyword Baiting Trigger
  • Taint TrackingDirect Taint Flow, Variable-Mediated Taint Flow, Credential Exfiltration Chain
Findings (54)

Tainted flow: 'gateway_url' from os.environ.get (line 30, credential/environment) → requests.patch (network output)

Critical
Category
Data Flow
Confidence
96% confidence
Finding

The code sends the provided API key to a URL taken directly from the OPENCLAW_GATEWAY_URL environment variable, defaulting to plain HTTP. If that variable is influenced by an attacker or misconfigured, the secret can be exfiltrated to an arbitrary host, and use of HTTP permits interception in transit. In this skill context, handling credentials is already outside the declared item-selection purpose, which makes the behavior more suspicious and increases risk.

Content

Scanner excerpt · scripts/capabilities/configure/service.py (reported line 37)May include surrounding context.

python
headers = {}
        if token:
            headers["Authorization"] = f"Bearer {token}"
        resp = requests.patch(f"{gateway_url}/api/config", headers=headers, json=payload, timeout=5)
        return resp.ok
    except Exception:
        return False

Tp4

High
Category
MCP Tool Poisoning
Confidence
99% confidence
Finding

The skill description omits that it includes AK configuration, validation, and persistence behavior, which means it processes and stores sensitive credentials beyond the advertised recommendation/search function. Undisclosed credential-handling logic is dangerous because users may invoke the skill expecting analytics while it also writes secrets to local configuration and performs authentication workflows.

Content

No source excerpt is available for this finding.

Tp4

High
Category
MCP Tool Poisoning
Confidence
99% confidence
Finding

The skill description omits that it includes AK configuration, validation, and persistence behavior, which means it processes and stores sensitive credentials beyond the advertised recommendation/search function. Undisclosed credential-handling logic is dangerous because users may invoke the skill expecting analytics while it also writes secrets to local configuration and performs authentication workflows.

Content

No source excerpt is available for this finding.

Tp4

High
Category
MCP Tool Poisoning
Confidence
99% confidence
Finding

The skill description omits that it includes AK configuration, validation, and persistence behavior, which means it processes and stores sensitive credentials beyond the advertised recommendation/search function. Undisclosed credential-handling logic is dangerous because users may invoke the skill expecting analytics while it also writes secrets to local configuration and performs authentication workflows.

Content

No source excerpt is available for this finding.

Tp4

High
Category
MCP Tool Poisoning
Confidence
98% confidence
Finding

The skill description omits that it includes AK configuration, validation, and persistence behavior, which means it processes and stores sensitive credentials beyond the advertised recommendation/search function. Undisclosed credential-handling logic is dangerous because users may invoke the skill expecting analytics while it also writes secrets to local configuration and performs authentication workflows.

Content

No source excerpt is available for this finding.

Tp4

High
Category
MCP Tool Poisoning
Confidence
94% confidence
Finding

The skill description omits that it includes AK configuration, validation, and persistence behavior, which means it processes and stores sensitive credentials beyond the advertised recommendation/search function. Undisclosed credential-handling logic is dangerous because users may invoke the skill expecting analytics while it also writes secrets to local configuration and performs authentication workflows.

Content

No source excerpt is available for this finding.

Tp4

High
Category
MCP Tool Poisoning
Confidence
99% confidence
Finding

The skill description omits that it includes AK configuration, validation, and persistence behavior, which means it processes and stores sensitive credentials beyond the advertised recommendation/search function. Undisclosed credential-handling logic is dangerous because users may invoke the skill expecting analytics while it also writes secrets to local configuration and performs authentication workflows.

Content

No source excerpt is available for this finding.

Tp4

High
Category
MCP Tool Poisoning
Confidence
97% confidence
Finding

The skill description omits that it includes AK configuration, validation, and persistence behavior, which means it processes and stores sensitive credentials beyond the advertised recommendation/search function. Undisclosed credential-handling logic is dangerous because users may invoke the skill expecting analytics while it also writes secrets to local configuration and performs authentication workflows.

Content

No source excerpt is available for this finding.

Tp4

High
Category
MCP Tool Poisoning
Confidence
97% confidence
Finding

The skill description omits that it includes AK configuration, validation, and persistence behavior, which means it processes and stores sensitive credentials beyond the advertised recommendation/search function. Undisclosed credential-handling logic is dangerous because users may invoke the skill expecting analytics while it also writes secrets to local configuration and performs authentication workflows.

Content

No source excerpt is available for this finding.

Credential Access

High
Category
Privilege Escalation
Confidence
60% confidence
Finding

Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.

Content

Scanner excerpt · scripts/_tracker.py (reported line 20)May include surrounding context.

python
_ROOT_DIR = Path(__file__).parent.parent

def _load_env_file() -> None:
    """解析项目根目录的 .env 文件,将变量注入 os.environ(已有环境变量不覆盖)。"""
    env_path = _ROOT_DIR / ".env"
    if not env_path.exists():
        return

Credential Access

High
Category
Privilege Escalation
Confidence
60% confidence
Finding

Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.

Content

Scanner excerpt · scripts/_tracker.py (reported line 35)May include surrounding context.

python
_ROOT_DIR = Path(__file__).parent.parent

def _load_env_file() -> None:
    """解析项目根目录的 .env 文件,将变量注入 os.environ(已有环境变量不覆盖)。"""
    env_path = _ROOT_DIR / ".env"
    if not env_path.exists():
        return

Credential Access

High
Category
Privilege Escalation
Confidence
60% confidence
Finding

Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.

Content

Scanner excerpt · scripts/_tracker.py (reported line 21)May include surrounding context.

python
def _load_env_file() -> None:
    """解析项目根目录的 .env 文件,将变量注入 os.environ(已有环境变量不覆盖)。"""
    env_path = _ROOT_DIR / ".env"
    if not env_path.exists():
        return
    with open(env_path, encoding="utf-8") as f:

Description-Behavior Mismatch

High
Category
Not specified by scanner
Confidence
99% confidence
Finding

The file implements AK credential configuration logic, which is materially unrelated to the declared skill purpose of 1688 item selection, scoring, and search. This capability expands the trust boundary by collecting and persisting secrets, making the skill more dangerous because users invoking a product-selection skill would not reasonably expect credential-management behavior.

Content

No source excerpt is available for this finding.

Description-Behavior Mismatch

High
Category
Not specified by scanner
Confidence
97% confidence
Finding

This file implements API-key configuration, gateway updates, and local secret persistence even though the skill is described as a product-selection/search capability. That mismatch is a supply-chain risk because the skill possesses hidden credential-management functionality not justified by its manifest, expanding the trust boundary and creating opportunity for secret collection or misuse.

Content

No source excerpt is available for this finding.

Undeclared Tool Scope

Medium
Category
MCP Least Privilege
Confidence
88% confidence
Finding

The skill declares executable capabilities that imply environment access, file reads/writes, and network use, but it does not scope or constrain those capabilities with an explicit permissions/allowed-tools policy. In this skill’s context, that matters because it handles an Access Key, reads local files like .env/references, and sends data to an external gateway, so the absence of explicit tool boundaries increases the chance of overbroad execution or unintended data exposure.

Content

No source excerpt is available for this finding.

Vague Triggers

Medium
Category
Not specified by scanner
Confidence
94% confidence
Finding

The trigger list includes broad phrases like 选品, 推荐商品, and 搜索商品, which are common in ordinary conversation and can cause accidental invocation. In this skill’s context, accidental runs matter because invocation may lead to external data access, telemetry submission, and credential-dependent operations against shop data.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
91% confidence
Finding

The description around command usage does not clearly warn users that execution requires handling a sensitive Access Key and that command runs report data to an external gateway. Insufficient upfront disclosure is dangerous because users may unknowingly expose credentials or business metadata under the assumption the skill is a simple local scoring helper.

Content

No source excerpt is available for this finding.

Intent-Code Divergence

Medium
Category
Not specified by scanner
Confidence
98% confidence
Finding

The security declaration marks configure as 'read-only' even though the command sets or updates an Access Key, which is a state-changing write operation involving sensitive material. Mislabeling a credential-writing command as harmless can bypass user caution and approval expectations, increasing the risk of unsafe secret handling or unintended persistence.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
88% confidence
Finding

The CLI unconditionally reports usage telemetry after every command via _tracker.report_skill_usage() and this file does not disclose that behavior or provide consent/opt-out controls. In a merchant analytics skill, command usage may reveal sensitive business interests, operational patterns, or query intent even if command execution succeeds, creating a privacy and transparency risk.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Medium
Category
Not specified by scanner
Confidence
93% confidence
Finding

The natural-language content of the skill file is entirely in Chinese, including usage instructions, output descriptions, and error guidance. Under the stated policy, forcing a specific language without user opt-in or an explicit documented justification constitutes a language/locale policy violation.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Medium
Category
Not specified by scanner
Confidence
90% confidence
Finding

The file presents all user-facing instructions, parameters, and warnings exclusively in Chinese. Under the policy rule for language or locale constraints, this effectively forces a specific language without user opt-in, and there is no indication that the skill is intentionally restricted to a Chinese-speaking or region-specific audience.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Medium
Category
Not specified by scanner
Confidence
95% confidence
Finding

The file title and all instructional content are written in Chinese, with only a brief English gloss in the title, and there is no statement that another language may be used. Under the policy, forcing a specific language without opt-in is a natural-language locale violation unless clearly justified or optional.

Content

No source excerpt is available for this finding.

Context-Inappropriate Capability

Medium
Category
Not specified by scanner
Confidence
89% confidence
Finding

The module falls back to reading API credentials from a local gateway configuration file, expanding the credential trust boundary beyond the intended environment-variable injection path. This increases the chance that the skill can access secrets from host-local configuration without explicit user intent, and in a plugin/agent context that is a meaningful secret-handling weakness even if no exfiltration is shown in this file.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Medium
Category
Not specified by scanner
Confidence
84% confidence
Finding

The file contains user- or maintainer-facing natural-language text only in Chinese, such as the module docstring and comments, with no indication that the language choice is optional or region-specific. Under the language/locale policy, forcing a specific language without opt-in can be a policy concern.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Medium
Category
Not specified by scanner
Confidence
93% confidence
Finding

This file contains user-facing natural-language text in Chinese in the module docstring and default exception messages. Under the policy, forcing a specific language without user opt-in can be a locale/language policy violation, and there is no indication here that the skill is intentionally region-specific or that users can choose another language.

Content

No source excerpt is available for this finding.