Intent-Code Divergence
Medium
- Confidence
- 95% confidence
- Finding
- `check_approval_needed` does not actually inspect on-chain allowance or query an allowance endpoint; it always returns `needs_approval: True`. In a trading skill, this can mislead downstream agents or users into submitting unnecessary approval transactions, increasing gas costs and potentially prompting repeated or excessive token approvals to a spender.
