Quotation Workflow

This skill appears to implement the advertised quotation workflow, but there are several practical inconsistencies you should resolve before installing or letting an agent run it autonomously: - Review env-var use: the scripts check QUOTATION_DEV_ENV to allow --skip-validation, but that variable is not declared in the skill metadata. If you plan to use skip-validation, be explicit about where/how QUOTATION_DEV_ENV is set and restrict it to dev shells. - Check required binaries: examples and docs use 'soffice' (LibreOffice) for PDF conversion but the metadata only lists 'chrome' and 'python3'. Install and test LibreOffice or update the skill metadata to include it. - Audit cross-skill/service calls: the skill references OKKI and SMTP flows (okki-sync.js, smtp.js). If you enable those, they will require credentials (OKKI API keys, SMTP creds). Those credentials are not declared — verify how and where they will be provided and stored before enabling integrations. - Inspect scripts for network activity: currently OKKI verification is a placeholder, but future P1/P2 work intends network calls. Search the repository for HTTP/network libraries (requests, urllib, node fetch) and confirm endpoints and auth behavior. - Test in isolation: run the validation and generation scripts locally on non-sensitive sample files to confirm behavior (they call sys.exit(1) on validation failure, which blocks automation when appropriate). - Principle of least privilege: only provide external credentials (CRM, SMTP) to the agent if you trust and have reviewed the code that will use them; prefer injecting credentials at runtime rather than baking them into environment or repository. If you want, I can: (1) list all places the code references environment variables and external programs, (2) scan the scripts for network calls and external endpoints, or (3) produce a short checklist of changes to make the skill metadata consistent (declare soffice and QUOTATION_DEV_ENV, and enumerate required credentials if OKKI/SMTP will be used).